Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Replaced Result by panic in boolean comparison #1159

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

When two arrays do not have the same number of elements, it is a programmatic error to call a binary operator on them. This is better represented by a panic, since there is no way for a user to recover (it should have checked before). This is aligned with the rest of the binary operators we have.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1159 (cafe1a8) into main (6de9edf) will decrease coverage by 0.00%.
The diff coverage is 57.50%.

@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
- Coverage   83.67%   83.67%   -0.01%     
==========================================
  Files         365      365              
  Lines       35865    35863       -2     
==========================================
- Hits        30011    30008       -3     
- Misses       5854     5855       +1     
Impacted Files Coverage Δ
src/compute/boolean_kleene.rs 68.35% <38.46%> (-6.01%) ⬇️
src/compute/boolean.rs 97.22% <87.50%> (+2.62%) ⬆️
src/compute/comparison/mod.rs 54.07% <100.00%> (-0.68%) ⬇️
src/array/utf8/mutable.rs 90.52% <0.00%> (+0.27%) ⬆️
src/io/ipc/read/common.rs 95.31% <0.00%> (+0.39%) ⬆️
src/io/ipc/read/reader.rs 96.65% <0.00%> (+0.66%) ⬆️
src/array/utf8/mod.rs 86.58% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de9edf...cafe1a8. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 26120da into main Jul 13, 2022
@jorgecarleitao jorgecarleitao deleted the boolean_cmp branch July 13, 2022 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant