Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made chunk_size optional in parquet's column_iter_to_arrays #1055

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

jorgecarleitao
Copy link
Owner

This allows reading incomplete column chunks, e.g. when the user wants to read page by page.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1055 (4767538) into main (6608071) will decrease coverage by 0.05%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
- Coverage   81.32%   81.27%   -0.06%     
==========================================
  Files         363      363              
  Lines       34649    34664      +15     
==========================================
- Hits        28179    28172       -7     
- Misses       6470     6492      +22     
Impacted Files Coverage Δ
src/io/parquet/read/deserialize/null.rs 0.00% <0.00%> (ø)
src/io/parquet/read/mod.rs 100.00% <ø> (ø)
src/io/parquet/read/deserialize/simple.rs 54.81% <75.00%> (-0.25%) ⬇️
src/io/parquet/read/deserialize/nested_utils.rs 83.93% <87.50%> (-0.21%) ⬇️
src/io/parquet/read/deserialize/binary/basic.rs 75.19% <100.00%> (ø)
...c/io/parquet/read/deserialize/binary/dictionary.rs 88.46% <100.00%> (ø)
src/io/parquet/read/deserialize/binary/mod.rs 100.00% <100.00%> (ø)
src/io/parquet/read/deserialize/binary/nested.rs 77.11% <100.00%> (+1.01%) ⬆️
src/io/parquet/read/deserialize/boolean/basic.rs 94.48% <100.00%> (ø)
src/io/parquet/read/deserialize/boolean/mod.rs 100.00% <100.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6608071...4767538. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 698c7b8 into main Jun 13, 2022
@jorgecarleitao jorgecarleitao deleted the pages branch June 13, 2022 04:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant