skip len checks on nested pages

jorgecarleitao · Jan 27, 2022 · bf675a2 · bf675a2
1 parent 542b4e9
commit bf675a2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/io/parquet/read/binary/mod.rs b/src/io/parquet/read/binary/mod.rs
@@ -40,6 +40,8 @@ where
         while let Some(page) = iter.next()? {
             basic::extend_from_page(page, metadata.descriptor(), &mut values, &mut validity)?
         }
+        debug_assert_eq!(values.len(), capacity);
+        debug_assert_eq!(validity.len(), capacity * usize::from(is_nullable));
     } else {
         while let Some(page) = iter.next()? {
             nested::extend_from_page(
@@ -52,8 +54,6 @@ where
             )?
         }
     }
-    debug_assert_eq!(values.len(), capacity);
-    debug_assert_eq!(validity.len(), capacity * usize::from(is_nullable));
     Ok(utils::finish_array(data_type, values, validity))
 }
 

diff --git a/src/io/parquet/read/boolean/mod.rs b/src/io/parquet/read/boolean/mod.rs
@@ -33,6 +33,8 @@ where
         while let Some(page) = iter.next()? {
             basic::extend_from_page(page, metadata.descriptor(), &mut values, &mut validity)?
         }
+        debug_assert_eq!(values.len(), capacity);
+        debug_assert_eq!(validity.len(), capacity * usize::from(is_nullable));
     } else {
         while let Some(page) = iter.next()? {
             nested::extend_from_page(
@@ -45,8 +47,6 @@ where
             )?
         }
     }
-    debug_assert_eq!(values.len(), capacity);
-    debug_assert_eq!(validity.len(), capacity * usize::from(is_nullable));
 
     Ok(Box::new(BooleanArray::from_data(
         data_type,

diff --git a/src/io/parquet/read/primitive/mod.rs b/src/io/parquet/read/primitive/mod.rs
@@ -84,6 +84,8 @@ where
         while let Some(page) = iter.next()? {
             basic::extend_from_page(page, metadata.descriptor(), &mut values, &mut validity, op)?
         }
+        debug_assert_eq!(values.len(), capacity);
+        debug_assert_eq!(validity.len(), capacity * usize::from(is_nullable));
     } else {
         while let Some(page) = iter.next()? {
             nested::extend_from_page(
@@ -97,8 +99,6 @@ where
             )?
         }
     }
-    debug_assert_eq!(values.len(), capacity);
-    debug_assert_eq!(validity.len(), capacity * usize::from(is_nullable));
 
     let data_type = match data_type {
         DataType::Dictionary(_, values, _) => values.as_ref().clone(),