Check if an option has a default value before we try to look it up. #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes fpm when used with clamp 1.3.0 or above. Fixes #1543
This was referenced Oct 16, 2018
|
Why has the build failed? |
|
@jordansissel I have manually applied this fix on fpm-1.9.3 - the command runs successfully, but the resulting packages are 0 bytes. I'm not sure what went wrong. |
|
@jordansissel I've tested this and it seems to work fine for me (clamp is at 1.3.2). |
|
@Apteryks Thank you for testing :) |
|
Any chance for a new release with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes fpm when used with clamp 1.3.0 or above.
Fixes #1543