-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rexml - rexml broken in Ruby versions below 2.3 #1800
Comments
Good old XML ... may it rest in peace. (I stopped using XML already in 2005 or so, at the least for my own projects. YAML replaced my personal needs in this regard.) |
#1950 should fix this by moving delaying the loading of rexml and only using that library when attempting to read a macOS |
#1950 is merged. Closing this :) |
fpm 1.15.0 is released and, I believe, has resolve this issue. Please let me know if you find otherwise in a new issue (if a new problem) or this issue (if same problem) |
Another game to play just like #1795. This time, it's
rexml
.rexml
is a direct dependency in fpm and is used by only one place,osxpkg.rb
https://github.com/jordansissel/fpm/blob/master/lib/fpm/package/osxpkg.rb#L107
It looks like this code is only used when
fpm -s osxpkg ...
(using an osx package as source/input to fpm).I'm guessing we can probably remove
rexml
and parse the xml ourselves without a library.fpm/lib/fpm/package/osxpkg.rb
Lines 108 to 110 in dbd8baf
It's used to grab the attributes from what looks like
<pkg-info identifier="..." version="...">
element.Reference: #1784 and #1798
The text was updated successfully, but these errors were encountered: