1.12 seems to have broken --before-upgrade and --after-upgrade #1750
Comments
|
Same problem - curl -sSL https://rvm.io/mpapis.asc | gpg --import -
- curl -sSL https://rvm.io/mpapis.asc | gpg2 --import -
- curl -sSL https://rvm.io/pkuczynski.asc | gpg2 --import -
- curl -L get.rvm.io | bash -s stable
- source /etc/profile.d/rvm.sh
- rvm reload
- rvm requirements run
- rvm install 2.3.0 -j 50
- rvm list
- gem install --no-ri --no-rdoc fpm
- fpm --versionExecute: fpm -s dir -t rpm -n apps Error: :message=>"error: line 72: Too many names: %pre upgrade() |
|
The same for me : Centos 7, RPM packaging, --before-upgrade --after-upgrade flags |
|
The changes in 8a40cd1 eat too much whitespace: When no It should be (and was, prior to v1.12.0): |
|
(Same for the other macro's: |
|
After some testing, I believe the final Can anyone confirm? |
The previous commit eats too much whitespace after the section headers
(`%pre`, `%post` etc.). There should remain a newline.
Correct versions (for `%pre`):
```
%pre
ugrade () {
```
and
```
%pre -e
upgrade() {
```
Without this patch, we get these (wrong):
```
%pre ugrade () {
```
and
```
%pre -e upgrade() {
```
(exact number of spaces can be different, but should not be relevant)
Fixes jordansissel#1750
Signed-off-by: Jo Vandeginste <[email protected]>
|
I have seen the same error message as well after attempting to use
I have not tried your fix @jovandeginste I can try it later today |
The previous commit eats too much whitespace after the section headers
(`%pre`, `%post` etc.). There should remain a newline.
Correct versions (for `%pre`):
```
%pre
ugrade () {
```
and
```
%pre -e
upgrade() {
```
Without this patch, we get these (wrong):
```
%pre ugrade () {
```
and
```
%pre -e upgrade() {
```
(exact number of spaces can be different, but should not be relevant)
Fixes jordansissel#1750
Signed-off-by: Jo Vandeginste <[email protected]>
The previous commit eats too much whitespace after the section headers
(`%pre`, `%post` etc.). There should remain a newline.
Correct versions (for `%pre`):
```
%pre
ugrade () {
```
and
```
%pre -e
upgrade() {
```
Without this patch, we get these (wrong):
```
%pre ugrade () {
```
and
```
%pre -e upgrade() {
```
(exact number of spaces can be different, but should not be relevant)
Fixes #1750
Signed-off-by: Jo Vandeginste <[email protected]>
We have a build using these flags, and after upgrading fpm to 1.12 the build started failing. If I revert to 1.11, or just remove these two flags from the build it works fine.
Error message:
Process failed: rpmbuild failed (exit code 1). Full command was:["rpmbuild", "-bb", "--target", "noarch", "--define", "buildroot /tmp/package-rpm-build-06b8fa1624894ee4291366ab54c0ecea4b49cc64c8cc61f9103a9f411ef9/BUILD", "--define", "_topdir /tmp/package-rpm-build-06b8fa1624894ee4291366ab54c0ecea4b49cc64c8cc61f9103a9f411ef9", "--define", "_sourcedir /tmp/package-rpm-build-06b8fa1624894ee4291366ab54c0ecea4b49cc64c8cc61f9103a9f411ef9", "--define", "_rpmdir /tmp/package-rpm-build-06b8fa1624894ee4291366ab54c0ecea4b49cc64c8cc61f9103a9f411ef9/RPMS", "--define", "_tmppath /tmp", "/tmp/package-rpm-build-06b8fa1624894ee4291366ab54c0ecea4b49cc64c8cc61f9103a9f411ef9/SPECS/file-mover.spec"] {:level=>:error}The text was updated successfully, but these errors were encountered: