Fix crash when showing diff of empty protocol #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing the checkboxes "Mark diffs in protocol", "Show only diffs in protocol" or "Show only labels in protocol" in the Analysis tab would crash the app if no rows are available.
|
|
jopohl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing the checkboxes "Mark diffs in protocol", "Show only diffs in protocol" or "Show only labels in protocol" in the Analysis tab would crash the app if no rows are available.
Traceback (most recent call last):
File "/urh/src/urh/controller/CompareFrameController.py", line 1398, in on_ref_index_changed
self.protocol_model.refindex = (new_ref_index + hide_correction) % self.protocol_model.row_count
ZeroDivisionError: integer division or modulo by zero