Add .cu8 .cs8 format alias #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Cool! I think if we have support for open, we should also be able to save as |
|
Yes, I already spotted that, wasn't sure if it would be acceptable. |
|
Why not? |
|
Just not sure if you perhaps don't want to confuse users with a redundant save option. To me cu8, cs8, cs16, cs12, cf32, s16, f64, … make a lot of sense, thanks for supporting that scheme! |
jopohl
requested changes
Jan 19, 2019
zuckschwerdt
force-pushed
the
feat-cu8
branch
from
697a7f3 to
25985a0
Compare
jopohl
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the popular .cu8 and .cs8 file name extensions as alias to .complex16u and .complex16s when opening files.