Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alignment action in analysis #458

Merged
merged 19 commits into from
Jun 24, 2018
Merged

Add alignment action in analysis #458

merged 19 commits into from
Jun 24, 2018

Conversation

jopohl
Copy link
Owner

@jopohl jopohl commented Jun 11, 2018

No description provided.

@jopohl jopohl changed the title Add alignment action in analysis [WIP] Add alignment action in analysis Jun 11, 2018
@jopohl jopohl changed the title [WIP] Add alignment action in analysis Add alignment action in analysis Jun 11, 2018
@jopohl jopohl requested a review from andynoack June 11, 2018 13:17
andynoack
andynoack requested changes Jun 13, 2018
View reviewed changes
Copy link
Collaborator

@andynoack andynoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work with assigning message types including labels as labels are assigned to the original position and not to the shifted (aligned) position

@jopohl jopohl merged commit 5ac33fa into master Jun 24, 2018
@jopohl jopohl deleted the align branch June 24, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andynoack andynoack andynoack requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jopohl @andynoack