Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow error when modulating very long messages #364

Merged
merged 1 commit into from
Nov 22, 2017
Merged

fix overflow error when modulating very long messages #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/urh/signalprocessing/Modulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,13 @@ def modulate(self, data=None, pause=0, start=0):
else:
f = self.carrier_freq_hz

arg = ((2 * np.pi * f * t + phi) * 1j).astype(np.complex64)
self.modulated_samples[:total_samples - pause] = a * np.exp(arg)
# it may be tempting to do this with complex exp, but exp overflows for large values!
# arg = ((2 * np.pi * f * t + phi) * 1j).astype(np.complex64)
# self.modulated_samples[:total_samples - pause] = a * np.exp(arg)

arg = (2 * np.pi * f * t + phi)
self.modulated_samples[:total_samples - pause].real = a * np.cos(arg)
self.modulated_samples[:total_samples - pause].imag = a * np.sin(arg)

def gauss_fir(self, bt=0.5, filter_width=1):
"""
Expand Down