Migrate to PyQt6 #1072
Open
Migrate to PyQt6 #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopohl
changed the title
jopohl
changed the title
|
@andynoack wdyt? Would appreciate if you could test this branch since a bunch of changes were necessary. The CI passes and I tested manually but from experience your eyes still catch bugs. ;) Please note the Cython extensions need to be rebuilt. |
|
Works fine for me! I am not sure whether we should push it to master yet if it drops Win32 support. Can we make a win32 survey or something like that? |
|
I have similar concerns. Previous version was downloaded over 1k times for Windows 32 bit Not sure, however, how many of those 32 bit downloads are accidental. There is also QtPy which acts as an abstraction layer and allows end-users to choose themselves between PyQt5 / PyQt6 / PySide2 and Pyside6. |
This reverts commit 5f2ba96.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates URH to PyQt6 and adds support for recent Python versions.
This PR drops support for 32-bit Windows since PyQt6 wheels are not available for this platform.