Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flipper raw #1000
Flipper raw #1000
Changes from 2 commits
6140edb
41fc1f9
d5cbef9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we rather check
as we refer to
dataline[1]
in the next line?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When re fails, dataline does not have a len. This code follows the concept from: https://gist.github.com/jinschoi/40a470e432c6ac244be8159145454b5c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious about the performance of this: As
arr
is a python list it needs to be converted to a numpy array down the road. Did we test loading larger sub files? Does it have an acceptable performance? An improvement would be to allocate a numpy array of desired size before entering the loop, e.g., witharr = np.zeros(N)
and then set its values in the loop.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually .sub files are rather small, so that wouldn't be a problem in practice. Due to the file format concept, you unfortunately do not know the number of samples beforehand. I would rather like to stick to the 1-pass solution and risk a slower performance for unusual large files.