Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"RClick>Create signal from selection" of already demodulated signal create a new signal and not a demodulated one #829

Closed
hcoohb opened this issue Dec 29, 2020 · 1 comment

Comments

@hcoohb
Copy link

hcoohb commented Dec 29, 2020

Expected Behavior

If I loaded an already demodulated signal (*.wav) file, then I want to select some sequence and create a new demodulated signal from that selection, the "RClick>Create signal from selection" should create a demodulated signal (same as the "parent")

Actual Behavior

"RClick>Create signal from selection" on a demodulated (*.wav) signal create a new signal which it tries to demodulate again...
Therefore we currently cannot split the demodulated import

Steps To Reproduce
  1. Load a demodulated *.wav file
  2. Select part of the signal
  3. "RClick>Create signal from selection"
    You can see that URH wants to demodulated the new signal created which is wrong as it already is demodulated
Screenshots
Platform Specifications
  • OS: Manjaro (Arch Linux)
  • URH version: 2.9.0
  • Python version: 3.8
  • Installed via manjaro packages

And also a big thanks for this software!

jopohl added a commit that referenced this issue Dec 29, 2020
@jopohl jopohl closed this as completed in 6a7048c Dec 29, 2020
@hcoohb
Copy link
Author

hcoohb commented Jan 4, 2021

That was a quick fix!
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant