Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference signal is not kept when disabling and re-enabling "Mark diffs in protocol" #441

Closed
Nesos-ita opened this issue May 29, 2018 · 0 comments
Assignees

Comments

@Nesos-ita
Copy link

Nesos-ita commented May 29, 2018

Expected Behavior

The selected reference signal is kept, for example if i have 7 rows and i click the 3° as reference, when disabling and re enabling mark diff it should be still the 3°

Actual Behavior

The reference signal is always the first row when i enable the checkbox.
If i hide some rows and keep only the 3° and the 5° rows the reference signal is yet the 1° row, even if it's hidden, this should be fixed too as noone probably want to compare two rows against one that has been intentionally hidden. (initially i thought about a bug in the diff itself, and only after i found out that it was the wrong reference signal)

Steps to Reproduce the Problem

  1. [optional] hide some rows, and the first row
  2. Enable mark diff
  3. Select a row as reference (right click->mark as reference) (not the 1° row)
  4. Disable mark diff
  5. Enable mark diff, the reference is 1° row (absolute number, not the first visible)

Platform Specifications

  • Python Version: installed 3.6 but it uses 3.5 included with the msi
  • Operating System: win8.1 x64
  • Version of URH: 2.0.4 MSI installer x64
  • URH was installed: via msi
@jopohl jopohl self-assigned this May 29, 2018
jopohl added a commit that referenced this issue May 29, 2018
@jopohl jopohl closed this as completed in d627bb4 May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants