Add custom Vault Authentication Path when using k8s login method #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
|
Hi @henryx, |
|
Hi @dttung2905, thank you for you PR, I've viewed it and for me is good. After the merge, I release ASAP the new version, to accomplish your work. In future, feel free to write tests for this part (sadly, I have no idea how to mock them) |
|
@dttung2905 yes I've released the latest version. Sadly, for now, I cannot uploaded to Maven Central, so you need to build it manually |
|
@henryx thanks for the help to release. Is there any timeline that we can solve the maven central problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jopenlibs,
Thanks for maintaining this fork so actively. You are doing a great work for the community 🙏
This PR aims to solve the hardcoding authentication path for Vault. This is extracted from the official doc
This is related to another issue lensesio/secret-provider#46 that I'm trying to fix ( and hopefully pin the vaul-java-driver dependencies to your fork 🤞 )
Do let me know if you have any comments/ feedback on this.