-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing: New URL routing for Joomla #8256
Conversation
…omponentrouteradvanced
…ms into componentrulesitemid
…omponentrouteradvanced
…ms into componentrulesitemid
Fix CS issues that was found by Travis
…s pretty complex and throws errors in our testing environment
…into com_content_router_legacy
…-cms into com_content_router_legacy
…omponentrouteradvanced
…iews in JComponentRouterAdvanced
…omponentrouteradvanced
…lasses except for JComponentRouterAdvanced
…ng unittests for JComponentRouterAdvanced
…ms into componentrulesitemid
This PR has received new commits. CC: @anibalsanchez, @Gitjk This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256. |
This PR has received new commits. CC: @anibalsanchez, @Gitjk This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256. |
This PR has received new commits. CC: @anibalsanchez, @Gitjk This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256. |
This PR has received new commits. CC: @anibalsanchez, @Gitjk This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256. |
This PR has received new commits. CC: @anibalsanchez, @Gitjk This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256. |
Hi folks, I cleaned up the code further, fixed the unittests and fixed the codestyle. Please give this another round of tests. To test, please apply these changes and enable the new routing in the global configuration. Then check the URLs of the site. The best would be, if you could test this on a copy of a real site. The sampledata of Joomla has already been tested and works. When you test these changes, the URLs should stay the same in most cases. The only time when the URL will be changed by this is when the menu item links to a category and the content item is in a child-child-category of the linked category. |
Hi again, |
@test |
Please alpha order new lang strings. |
@@ -168,6 +168,8 @@ COM_CONFIG_FIELD_PROXY_USERNAME_DESC="The username used to access the Proxy serv | |||
COM_CONFIG_FIELD_PROXY_USERNAME_LABEL="Proxy Username" | |||
COM_CONFIG_FIELD_SECRET_DESC="This is an auto-generated, unique alphanumeric code for every Joomla installation. It is used for security functions." | |||
COM_CONFIG_FIELD_SECRET_LABEL="Secret" | |||
COM_CONFIG_FIELD_SEF_ADVANCED_LABEL="Use new URL routing" | |||
COM_CONFIG_FIELD_SEF_ADVANCED_DESC="This uses the new URL routing. This will change your URLs!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will or may?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, it "may" change your URLs.
Tested on a news site, upgraded to Joomla 3.5, installed the new router, crawled Urls with Screaming Frog and compared results. No differences found in resulting Urls. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256. |
@Hackwar can you please update this PR to staging (conflicts atm). Got some more people to test on this |
Conflicts: components/com_content/router.php
This PR has received new commits. CC: @anibalsanchez, @Gitjk This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256. |
1 similar comment
This PR has received new commits. CC: @anibalsanchez, @Gitjk This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256. |
I've updated the branch. Please notice that I've moved the setting for advanced routing from the global configuration to the component configuration for each specific component. |
Merged into 3.6.x branch :) |
UsersHelperRoute::getLoginRoute(); is set to deprecated, what's the new call, or are the deprecated tags wrong on the j3.6/7 branch, because on the 4.0 branch its still there |
4.0 branch is currently based on staging not the 3.7 branch :) |
This is an updated PR from #7615
This PR implements a new routing system for Joomla, based on what has been proposed here: http://www.joomlager.de/crowdfunding
This is a combined PR of the former changes from #5446, #5501, #5502. #5503, #5509, #5599 and #5604.
Please test and comment. For further informations, read the other 7 PRs.