Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing: New URL routing for Joomla #8256

Closed
wants to merge 113 commits into from
Closed

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Nov 3, 2015

This is an updated PR from #7615

This PR implements a new routing system for Joomla, based on what has been proposed here: http://www.joomlager.de/crowdfunding

This is a combined PR of the former changes from #5446, #5501, #5502. #5503, #5509, #5599 and #5604.

Please test and comment. For further informations, read the other 7 PRs.

Hackwar and others added 30 commits December 16, 2014 16:51
Fix CS issues that was found by Travis
…s pretty complex and throws errors in our testing environment
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @anibalsanchez, @Gitjk


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @anibalsanchez, @Gitjk


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @anibalsanchez, @Gitjk


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @anibalsanchez, @Gitjk


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @anibalsanchez, @Gitjk


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.

@Hackwar
Copy link
Member Author

Hackwar commented Jan 8, 2016

Hi folks, I cleaned up the code further, fixed the unittests and fixed the codestyle. Please give this another round of tests.

To test, please apply these changes and enable the new routing in the global configuration. Then check the URLs of the site. The best would be, if you could test this on a copy of a real site. The sampledata of Joomla has already been tested and works. When you test these changes, the URLs should stay the same in most cases. The only time when the URL will be changed by this is when the menu item links to a category and the content item is in a child-child-category of the linked category.

@Gitjk
Copy link

Gitjk commented Jan 8, 2016

Hi again,
Just had a short (10 Minute) look. Used latest staging Joomla and VirtueMart 3.0.12, both bilingual. After adding #8256 with the patch-tester, I didn't see any difference in urls with 'Use new URL routing' enabled/disabled. Seems to work fine at the first glance. I might have another look on Sunday.

@infograf768
Copy link
Member

@test
Looks like working fine here on my multilingual test site, sef on.
Did not test the child-child situation yet.

@infograf768
Copy link
Member

Please alpha order new lang strings.

@@ -168,6 +168,8 @@ COM_CONFIG_FIELD_PROXY_USERNAME_DESC="The username used to access the Proxy serv
COM_CONFIG_FIELD_PROXY_USERNAME_LABEL="Proxy Username"
COM_CONFIG_FIELD_SECRET_DESC="This is an auto-generated, unique alphanumeric code for every Joomla installation. It is used for security functions."
COM_CONFIG_FIELD_SECRET_LABEL="Secret"
COM_CONFIG_FIELD_SEF_ADVANCED_LABEL="Use new URL routing"
COM_CONFIG_FIELD_SEF_ADVANCED_DESC="This uses the new URL routing. This will change your URLs!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will or may?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it "may" change your URLs.

@anibalsanchez
Copy link
Contributor

Tested on a news site, upgraded to Joomla 3.5, installed the new router, crawled Urls with Screaming Frog and compared results. No differences found in resulting Urls.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.

@wilsonge
Copy link
Contributor

@Hackwar can you please update this PR to staging (conflicts atm). Got some more people to test on this

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @anibalsanchez, @Gitjk


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.

1 similar comment
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @anibalsanchez, @Gitjk


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.

@Hackwar
Copy link
Member Author

Hackwar commented Jan 29, 2016

I've updated the branch. Please notice that I've moved the setting for advanced routing from the global configuration to the component configuration for each specific component.

wilsonge pushed a commit that referenced this pull request Feb 20, 2016
@wilsonge wilsonge closed this Feb 20, 2016
@wilsonge
Copy link
Contributor

Merged into 3.6.x branch :)

@wilsonge wilsonge modified the milestones: Joomla 3.7.0, Joomla 3.6.0 May 11, 2016
@810
Copy link
Contributor

810 commented Oct 5, 2016

UsersHelperRoute::getLoginRoute(); is set to deprecated, what's the new call, or are the deprecated tags wrong on the j3.6/7 branch, because on the 4.0 branch its still there

@wilsonge
Copy link
Contributor

wilsonge commented Oct 5, 2016

4.0 branch is currently based on staging not the 3.7 branch :)

@Hackwar Hackwar deleted the routing branch April 27, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.