[5.3] Language Association Codes

[brianteeman]

In the Language Code plugin it is possible to change the code used for a specified language. eg fr-FR can be changed to fr-CA

However everywhhere in the admin that associations are displayed it uses the original code and not the changed code.

This PR is a "takeover" of the original PR #37289 created by @infograf768

That PR has merge conflicts and @infograf768 is now retired.

See the original PR for more screenshots

Testing Instructions

Create a multilingual site.
Enable the languagecode system plugin and give a new lang tag value for a language.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[fgsw]

I have tested this item ✅ successfully on 8ccef0c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44551.}

[Fedik]

The feature maybe is good and usefull.
However the implementation is questionable, because hardcoding if (PluginHelper::isEnabled('system', 'languagecode')) everywhere promisses a loot of fun bugs.

Need to look for a better way of doing the same, maybe some extra event, or kind of that.

[universewrld]

@brianteeman will it work if instead of en-GB i just use en?
in your screenshots it is shown only for language+country codes.

[brianteeman]

@brianteeman will it work if instead of en-GB i just use en? in your screenshots it is shown only for language+country codes.

yes but then then language code wont work as intended.

[fgsw]

Prebuilt packages are not available for a retest.

[richard67]

Prebuilt packages are not available for a retest.

@fgsw Yes, they are deleted after a while. I've updated the branch so a new build was triggered, and now packages are available.

[fgsw]

I have tested this item ✅ successfully on 6cc6c8c

Before	After

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44551.}

[crimle]

I have tested this item ✅ successfully on 6cc6c8c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44551.}

[alikon]

PBF

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44551.}

[Fedik]

I am sorry, but this cannot be merged, because of hardcoding if (PluginHelper::isEnabled('system', 'languagecode')).
We need to find a better logic.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44551.}

[brianteeman]

I dont understand your reasoning. PluginHelper::isEnabled is used over 50 times in the core

[Fedik]

It not an issue with PluginHelper::isEnabled, but with hardcoded plugin itself.

In the core, the plugins should never be used like:

 $languageCodeParams = new Registry(PluginHelper::getPlugin('system', 'languagecode')->params);

What if I want to use 3rd language plugin? With current approach the whole thing will not going to work.

The plugins should listen to events, instead of being used directly.
For current issue, it could be a new event that hook up in to LanguageHelper::getContentLanguages and extend it, or kind of that.

[brianteeman]

As i said this is already being used in core

joomla-cms/administrator/components/com_redirect/src/Helper/RedirectHelper.php

Lines 93 to 95 in 64ac8c8

	if (PluginHelper::isEnabled('system', 'redirect')) {
	$params = new Registry(PluginHelper::getPlugin('system', 'redirect')->params);
	$collect_urls = (bool) $params->get('collect_urls', 1);

[Fedik]

That another bad code, and not an excuse to do the same.

[brianteeman]

When infograf wrote the code I assume he just followed existing practice