-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link and button colors in header footer of Cassiopeia template #42504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-4.4-dev
labels
Dec 13, 2023
The Download is not available ( |
the Prebuilt Download Packages are available here https://artifacts.joomla.org/drone/joomla/joomla-cms/4.4-dev/42504/downloads/72256 |
Thanks for this pr. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42504. |
I have tested this item ✅ successfully on 22dc444 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42504. |
4 tasks
I have tested this item ✅ successfully on 22dc444 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42504. |
Thank you! |
Razzo1987
added a commit
that referenced
this pull request
Jan 4, 2024
* Fix link and button colors in header footer (#42504) * [4.x] add php 8.3 to tests (#42545) * Update the signature for #42545 (#42552) * [4.4] Joomlaupdate remove br tag from language strings - follow up to PR 42489 (#42550) * Better English (1) * Better English (2) * Remove br html element from language strings * Fixes to form validation process (#42560) Fixes hardening measure introduced in #23716 * [4][com_actionlogs] missed load plugin languages (#42562) * load lang * test-4-dupkey * Better message on package uninstallation (#42570) * Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 . * backport #41865 (#42088) * backport [5] update from nightly to latest nightly build #41865 * [5] harmonize naming task types (#42574) * [5.0] colour contrast in media manager file list [a11y] (#42544) * [5.0] Update phpseclib to 3.0.34 (#42469) * Fix `function` parameter lost during redirect (#42315) * Fix `function` parameter lost during redirect * Move function parameter to form url * Remove hidden input * [4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576) * Use concat of columns for getting core extensions * Fix PHPCS * Remove wrong quotes * Revert min version in drone (#42583) * Joomla! 5.0.2 Release Candidate 1 * Revert to dev * [4][com_templates] cast to int for pgsql (#42569) * cast to int for pgsql * yet-another * patch article tags (#42486) * Joomla 5.0.2 Release Candidate 2 * Reset to dev * Update signature HMAC in .drone.yml --------- Co-authored-by: Rick Spaan <[email protected]> Co-authored-by: Christian Heel <[email protected]> Co-authored-by: Allon Moritz <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: George Wilson <[email protected]> Co-authored-by: Nicola Galgano <[email protected]> Co-authored-by: Benjamin Trenkle <[email protected]> Co-authored-by: Benjamin Trenkle <[email protected]> Co-authored-by: David Jardin <[email protected]> Co-authored-by: janschoenherr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of issue PR #41749
Pull Request for Issue #42302
Summary of Changes
In previous PR's the colors for the buttons and links in the header and footer where broken. This PR fixed those issues,
Testing Instructions
Create 3 custom html modules in the positions: topbar / footer / bottom-b
Make sure you toggle the editor to Source code+ (Click in the editor Tools -> Source code+)
Use the code below in the modules and paste as in the Source code+ ans click Save.
Test if all button color are correct, also the hover state.
Test the frontend edit buttons
Switch the scroll to top icon to On in the template settings to test the scroll to top hover color
Actual result BEFORE applying this Pull Request
Some buttons and links texts are not visible
Expected result AFTER applying this Pull Request
All colors are visible
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed