[4.4] Update phpseclib/phpseclib PHP dependency to fix issue with JIT on Windows 11 #42190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42142 .
Summary of Changes
This pull request (PR) updates the composer dependency "phpseclib/phpseclib" from version 3.0.23 to the just released version 3.0.33. Despite of the increase of the patch version by 10 it is the next version after 3.0.23. See https://github.com/phpseclib/phpseclib/releases .
This solves issue #42142 .
According to their list of changes for that release it doesn't seem to include any breaking changes, only bugfixes.
Testing Instructions
It needs Windows 11 and just-in-time (JIT) compilation enabled.
Install Joomla.
Check that everything works as expected.
Actual result BEFORE applying this Pull Request
Execution fails with exception "JIT on Windows is not currently supported"
caused by "../libraries/vendor/phpseclib/phpseclib/bootstrap.php" at line 24
Expected result AFTER applying this Pull Request
Site (frontend) and admin (backend) work as expected.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed