[5.0] Update deleted files list in script.php for 5.0.0-alpha3 #41211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
changed the title
wilsonge
reviewed
Jul 23, 2023
richard67
changed the title
wilsonge
approved these changes
Jul 23, 2023
|
thanks |
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
…a#41211) * Add deleted files and folders from PRs joomla#40664 , joomla#41070 and joomla#41101 * Remove false alarm due to missing upmerge of PR joomla#41101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) updates the list of files to be deleted on update in file "administrator/components/com_admin/script.php" to recent changes in the 5.0-dev branch in preparation for the upcoming 5.0.0-alpha3 release.
In detail deleted files and folder from following PR's are added:
'/libraries/classmap.php',
'/libraries/extensions.classmap.php',
'/plugins/editors/codemirror/src/Field',
'/media/vendor/codemirror/theme',
'/media/vendor/codemirror/mode',
'/media/vendor/codemirror/lib',
'/media/vendor/codemirror/keymap',
'/media/vendor/codemirror/addon',
Testing Instructions
Code review.
Or if you want to make a real test, update a current 4.4-dev nightly build or a 5.0.0-alpha2 to the last 5.0 nightly build to get the actual result, and update a current 4.4-dev nightly build or a 5.0.0-alpha2 to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
The files and folders mentioned above are still present after updating from a current 4.4-dev nightly build or a 5.0.0-alpha2.
Expected result AFTER applying this Pull Request
The files mentioned above have been deleted after updating from a current 4.4-dev nightly build or a 5.0.0-alpha2.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed