[5.0] Remove obsolete uninstallEosPlugin method from script.php

[richard67]

Pull Request for Issue # .

Summary of Changes

This pull request (PR) removes the "uninstallEosPlugin" function from script.php and the one call to in the "update" function of the same file.

The function is obsolete in the 5.0 core because it handles uninstallation of the 3.10 EOS plugin, which is already uninstalled when updating from 3.10 to 4.x, and beginning with 4.4 and 5.0 there is a permanently installed EOS plugin which has been introduced with PR #40565 so it doesn't need to keep that function.

Possible B/C break to be approved by release managers

In opposite to previously removed, obsolete code in script.php for 5.0, this time the removed function is not private but protected.

That means that theoretically the method could be overridden in the installation scripts of 3rd party extension developers with code for doing own stuff when their scripts is based on the "JoomlaInstallerScript" class of our script.php.

But the name of that method is so specific to the core that I don't really think anybody has ever done that.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

File "administrator/components/com_admin/script.php" contains the obsolete function "uninstallEosPlugin" which is called only at one place in the public function "Update" of the same file.

Expected result AFTER applying this Pull Request

File "administrator/components/com_admin/script.php" doesn't contain anymore the obsolete function "uninstallEosPlugin" and any call to it.

Link to documentations

Not sure if it needs to be documented somewhere for the "JoomlaInstallerScript" class on manual.joomla.org that this method has been removed.

Please select:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[sandewt]

Should / can the language strings of the eos310 plugin also be removed yet for J5? What is the procedure for this?

See:

joomla-cms/administrator/language/en-GB/plg_quickicon_eos.ini

Line 22 in 934c75c

; Below is a copy of the 3.10 text definitions for reference.

[richard67]

Should / can the language strings of the eos310 plugin also be removed yet for J5? What is the procedure for this?

See:

joomla-cms/administrator/language/en-GB/plg_quickicon_eos.ini

Line 22 in 934c75c

; Below is a copy of the 3.10 text definitions for reference.

I think that either can be done in 4.4-dev and then be merged up into 5.0-dev because they are obsolete and only used by the core. But if we are strict regarding removal of language strings we might have to deprecate them now and remove with 6.0.

=> @HLeithner Any suggestions?

[sandewt]

I have tested this item ✅ successfully on 1fd0b2d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40711.}

[HLeithner]

Thanks