Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a UserFactoryAware interface #40337

Merged
merged 16 commits into from
Apr 19, 2023

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 5, 2023

Summary of Changes

Adds a new interface and trait to deal with a UserFactory class.

Testing Instructions

  • Log in on the back end
  • Open a user back end form

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo changed the title Introduce an UserFactoryAware interface Introduce a UserFactoryAware interface Apr 5, 2023
@MacJoom MacJoom self-assigned this Apr 14, 2023
@sandewt
Copy link
Contributor

sandewt commented Apr 15, 2023

Missing Name in User Actions Log after apply patch.

pr_40337

@laoneo
Copy link
Member Author

laoneo commented Apr 15, 2023

Thanks @sandewt for the test. Fixed it in 17cd076

@sandewt
Copy link
Contributor

sandewt commented Apr 15, 2023

I have tested this item ✅ successfully on 17cd076

  • Log in on the back end
  • Open a user back end form

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40337.

@MacJoom MacJoom merged commit 0e57bdd into joomla:4.4-dev Apr 19, 2023
@MacJoom MacJoom deleted the user/awarefactory branch April 19, 2023 16:21
@MacJoom MacJoom added this to the Joomla! 4.4.0 milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants