Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3][bug] Refresh list of parent menu items after menu selection has been changed #39659

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

SniperSister
Copy link
Contributor

@SniperSister SniperSister commented Jan 17, 2023

Pull Request for Issue #38792

Summary of Changes

This patch correctly refreshes the list of available parent menu item after the actual menu assignment has been changed. This prevents an incorrect configuration (parent menu item selected which does not belong to the selected menu) being stored.

Testing Instructions

  • Creata a J4 site with at least two menus and at least one menu item each
  • Change the menu assignment of one menu item
  • Check the available options in the parent menu item select

Actual result BEFORE applying this Pull Request

Parent menu select shows menu items of the old menu assignment.

Expected result AFTER applying this Pull Request

Parent menu select shows menu items of the new menu assignment.

Link to documentations

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Jan 17, 2023
@SniperSister SniperSister changed the title Refresh list of parent menu items after menu selection has been changed [4.3][bug] Refresh list of parent menu items after menu selection has been changed Jan 17, 2023
@chmst
Copy link
Contributor

chmst commented Jan 18, 2023

I have tested this item ✅ successfully on ad1c257


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on ad1c257


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659.

@Quy
Copy link
Contributor

Quy commented Jan 18, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 19, 2023
@obuisard obuisard merged commit 49e698c into joomla:4.3-dev Jan 19, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 19, 2023
@obuisard
Copy link
Contributor

Thank you David @SniperSister for the bug fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants