Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts the authentication plugins to service providers #39624

Merged
merged 8 commits into from
Jan 19, 2023

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jan 13, 2023

Summary of Changes

Converts the authentication plugins to service providers.

Testing Instructions

Log in on the back and front end. If possible also with Ldap.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@carlitorweb
Copy link
Member

carlitorweb commented Jan 13, 2023

@laoneo set session time in global configuration to 1min, and login after in the front using the "Remember me" button, close the page. Wait that minute and back again to the page

Notice
: Only variables should be passed by reference in
/var/www/192.168.1.103/bugtesting/plugins/authentication/cookie/services/provider.php
on line
39

@carlitorweb
Copy link
Member

carlitorweb commented Jan 13, 2023

Except ldap I could not test, the rest work okay. Let me know if the notice message is important enough...if not I can mark the test successfully

@laoneo
Copy link
Member Author

laoneo commented Jan 13, 2023

The notice should be fixed with the last commit. Thanks for reporting.

@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on 558f6dd

Remember clean autoload_psr4.php cached after apply the patch


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624.

@laoneo
Copy link
Member Author

laoneo commented Jan 15, 2023

@tatankat can you test this one here as well as it converts the ldap auth plugin to service provider?

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on c6c61b4

* the LDAP was not tested for actually authenticating (I don't have LDAP locally)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624.

@laoneo
Copy link
Member Author

laoneo commented Jan 19, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 19, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 19, 2023
@obuisard obuisard merged commit 8e559f9 into joomla:4.3-dev Jan 19, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 19, 2023
@obuisard
Copy link
Contributor

Thank you Allon @laoneo for the PR!

@laoneo laoneo deleted the provider/authentication branch January 20, 2023 04:15
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 21, 2023
@tatankat
Copy link
Contributor

A bit too late for the party, but I can confirm ldap works as it should. Thanks for also updating the ldap plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants