-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts the authentication plugins to service providers #39624
Converts the authentication plugins to service providers #39624
Conversation
@laoneo set session time in global configuration to 1min, and login after in the front using the "Remember me" button, close the page. Wait that minute and back again to the page
|
Except ldap I could not test, the rest work okay. Let me know if the notice message is important enough...if not I can mark the test successfully |
The notice should be fixed with the last commit. Thanks for reporting. |
I have tested this item ✅ successfully on 558f6dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624. |
@tatankat can you test this one here as well as it converts the ldap auth plugin to service provider? |
I have tested this item ✅ successfully on c6c61b4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39624. |
Thank you Allon @laoneo for the PR! |
Add deleted files from PRs joomla#39379 , joomla#39539 , joomla#39624 , joomla#39649 and joomla#39625 .
A bit too late for the party, but I can confirm ldap works as it should. Thanks for also updating the ldap plugin. |
Summary of Changes
Converts the authentication plugins to service providers.
Testing Instructions
Log in on the back and front end. If possible also with Ldap.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed