-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] PHP8.2 Remove the not used method assignment in mm API #39612
Conversation
@laoneo still the data not loading. But also is giving a js error Uncaught SyntaxError: Unexpected token '<', "<br />
<b>"... is not valid JSON
at JSON.parse (<anonymous>)
at onSuccess (media-manager.js?c9d04fea6dae2c821fd73c99da6c9835:8113:45)
at xhr.onreadystatechange (core.js?c9d04fea6dae2c821fd73c99da6c9835:669:23) [with 8.2 only] |
In the browser tools can you inspect the XHR request, what for a error message is displayed in the response? |
Sorry, forgot that:
|
But I confirm the error of the not used method variable and the patch fix it. The other error is not relate with this one |
I have tested this item ✅ successfully on d0c53b7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612. |
1 similar comment
I have tested this item ✅ successfully on d0c53b7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612. |
Thank you |
Summary of Changes
Removes the not used method variable in the media manager APIController.
Testing Instructions
Open the media manager on PHP 8.2
Actual result BEFORE applying this Pull Request
Media data is not loaded.
Expected result AFTER applying this Pull Request
Media data is loaded.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed