Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] PHP8.2 Remove the not used method assignment in mm API #39612

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jan 12, 2023

Summary of Changes

Removes the not used method variable in the media manager APIController.

Testing Instructions

Open the media manager on PHP 8.2

Actual result BEFORE applying this Pull Request

Media data is not loaded.

Expected result AFTER applying this Pull Request

Media data is loaded.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo added the PHP 8.x PHP 8.x deprecated issues label Jan 12, 2023
@carlitorweb
Copy link
Member

@laoneo still the data not loading. But also is giving a js error

Uncaught SyntaxError: Unexpected token '<', "<br />
<b>"... is not valid JSON
    at JSON.parse (<anonymous>)
    at onSuccess (media-manager.js?c9d04fea6dae2c821fd73c99da6c9835:8113:45)
    at xhr.onreadystatechange (core.js?c9d04fea6dae2c821fd73c99da6c9835:669:23)

[with 8.2 only]

@laoneo
Copy link
Member Author

laoneo commented Jan 13, 2023

In the browser tools can you inspect the XHR request, what for a error message is displayed in the response?

@carlitorweb
Copy link
Member

Sorry, forgot that:

<b>Deprecated</b>: Using ${var} in strings is deprecated, use {$var} instead in <b>www\bugtesting\joomla-cms\libraries\vendor\voku\portable-utf8\src\voku\helper\UTF8.php</b> on line <b>13409</b>

@carlitorweb
Copy link
Member

But I confirm the error of the not used method variable and the patch fix it. The other error is not relate with this one

@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on d0c53b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612.

1 similar comment
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on d0c53b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612.

@joomdonation
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 13, 2023
@joomdonation joomdonation added this to the Joomla! 4.2.7 milestone Jan 13, 2023
@roland-d roland-d merged commit 4004f91 into joomla:4.2-dev Jan 14, 2023
@roland-d roland-d deleted the php82/mm branch January 14, 2023 10:28
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 14, 2023
@roland-d
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants