Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] PHP8.2 Add the missing props to the password form field #39608

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jan 11, 2023

Summary of Changes

Define the missing properties in the PasswordField class to prevent deprecation notice on PHP 8.2.

Test by code review.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo added the PHP 8.x PHP 8.x deprecated issues label Jan 11, 2023
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on a1c61c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39608.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Jan 12, 2023

I have tested this item ✅ successfully on a1c61c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39608.

@joomdonation
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39608.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@HLeithner HLeithner merged commit bc6a5f3 into joomla:4.2-dev Jan 12, 2023
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@laoneo laoneo deleted the php82/field/password branch January 12, 2023 16:17
@Quy Quy added this to the Joomla! 4.2.7 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants