Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] PHP8.2 Define the folder property in the media form field #39602

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jan 11, 2023

Summary of Changes

Define the folder property in the MediaField class to prevent deprecation notice on PHP 8.2.

Testing Instructions

Open the article form on the PHP 8.2 on the back end with debug enabled.

Actual result BEFORE applying this Pull Request

The following warning is shown:
Creation of dynamic property Joomla\CMS\Form\Field\MediaField::$folder is deprecated in

Expected result AFTER applying this Pull Request

No warning.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo added PHP 8.x PHP 8.x deprecated issues and removed PR-4.2-dev labels Jan 11, 2023
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on afeada2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39602.

1 similar comment
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on afeada2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39602.

@Quy Quy added PR-4.2-dev and removed PHP 8.x PHP 8.x deprecated issues labels Jan 11, 2023
@Quy
Copy link
Contributor

Quy commented Jan 11, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39602.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 11, 2023
@Quy Quy added RTC This Pull Request is Ready To Commit PHP 8.x PHP 8.x deprecated issues and removed RTC This Pull Request is Ready To Commit labels Jan 11, 2023
@fancyFranci fancyFranci merged commit 6ad41b7 into joomla:4.2-dev Jan 11, 2023
@fancyFranci fancyFranci added this to the Joomla! 4.2.7 milestone Jan 11, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 11, 2023
@fancyFranci
Copy link
Contributor

Great to "see" another vanishing warning. Thank you!

@laoneo laoneo deleted the php82/field/media branch January 12, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants