[4.2] Fix radio form field required validation #39578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #39496.
Summary of Changes
Base on code at https://github.com/joomla/joomla-cms/blob/4.2-dev/build/media_source/system/js/fields/validate.es6.js#L192 and https://github.com/joomla/joomla-cms/blob/4.2-dev/build/media_source/system/js/fields/validate.es6.js#L194 , to validate a radio form field as required, the fieldset element in radio form field layout must has class attribute contains radio . The element also need to have required attribute or required in it's class.
Since required is not a valid attribute for fieldset element, I set class="required radio" when the field is required to address the issue.
Testing Instructions
Actual result BEFORE applying this Pull Request
The form is submitted even the radio field is a required field.
Expected result AFTER applying this Pull Request
Form is not submitted, an error message like below will be displayed:
The form cannot be submitted as it's missing required data.
Please correct the marked fields and try again.
Link to documentations
Please select: