Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Fix library autoloading #39348

Merged
merged 6 commits into from
Jan 14, 2023
Merged

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Dec 3, 2022

Summary of Changes

Fixes #39347.

This fixes some issues in namespace mapper regarding library extension autoloading. First, this changes the manifest lookup from JPATH_LIBRARIES to JPATH_MANIFESTS directory where library manifests are actually stored. Secondly, this adds support for the possibly undocumented "vendor" library structure.

Testing Instructions

See #39342 and #39347.

Documentation Changes Required

Although this PR is a bug fix, library autoloading and "vendor" library structure features are probably not documented. So documentation should be added somewhere.

@sergeytolkachyov
Copy link
Contributor

@SharkyKZ tested it successfully.

@joomdonation
Copy link
Contributor

@sergeytolkachyov Could you please go to https://issues.joomla.org/tracker/joomla-cms/39348 , click on Test this button and report your test result there so that your test will be counted? We require two successful tests for each PR before it can be merged.

@sergeytolkachyov
Copy link
Contributor

I have tested this item ✅ successfully on 326bfe2

Tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39348.

@joomdonation
Copy link
Contributor

Thanks @sergeytolkachyov

@richard67
Copy link
Member

I've restored @sergeytolkachyov 's test result because the commits which have invalidated the test counter were just removing a redundant variable declaration and a clean branch update. The PR should still work the same as before.

But I think it is not easy to test without having an example library following that vendor structure.

@sergeytolkachyov
Copy link
Contributor

I've restored @sergeytolkachyov 's test result because the commits which have invalidated the test counter were just removing a redundant variable declaration and a clean branch update. The PR should still work the same as before.

But I think it is not easy to test without having an example library following that vendor structure.

I'll test it again tomorrow.

@richard67
Copy link
Member

I'll test it again tomorrow.

@sergeytolkachyov No need to do that. Your test is still valid, I restored the counter.

@sergeytolkachyov
Copy link
Contributor

@richard67 what is currently missing for the merging of this pr?

@richard67
Copy link
Member

@richard67 what is currently missing for the merging of this pr?

@sergeytolkachyov A 2nd human test. Your test still counts, but each PR needs 2 human tests before it is set to RTC (ready to commit). After that a maintainer will merge it whenever they find time.

@sergeytolkachyov
Copy link
Contributor

I have tested this item ✅ successfully on 53f4b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39348.

1 similar comment
@leha123ra
Copy link

I have tested this item ✅ successfully on 53f4b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39348.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39348.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@roland-d roland-d merged commit 723aa0a into joomla:4.2-dev Jan 14, 2023
@roland-d
Copy link
Contributor

Thank you

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 14, 2023
@roland-d roland-d added this to the Joomla! 4.2.7 milestone Jan 14, 2023
@SharkyKZ SharkyKZ deleted the j4/fix/library-autoload branch January 16, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace for 3d-party libraries with library name like Vendor/Libraryname don't work
7 participants