Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Mark deprecation in DelegatingPsrLogger #39224

Merged
merged 1 commit into from
Nov 22, 2022
Merged

[4.3] Mark deprecation in DelegatingPsrLogger #39224

merged 1 commit into from
Nov 22, 2022

Conversation

nikosdion
Copy link
Contributor

See #39134 (comment)

Summary of Changes

\Joomla\CMS\Log\DelegatingPsrLogger was marked @internal and a deprecation notice information developers it will be marked final has been added.

Testing Instructions

None. This PR only changes the DocBlock.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: PR 61

@wilsonge wilsonge changed the title Mark deprecation in DelegatingPsrLogger [4.3] Mark deprecation in DelegatingPsrLogger Nov 16, 2022
@wilsonge
Copy link
Contributor

I'm probably being overly pedantic here but isn't this better off as a note rather than deprecated. Because people will still be able to init the class and it's not deprecated (in the short term anyhow) for that purpose?

@nikosdion
Copy link
Contributor Author

The idea is that if someone does Whatever extends \Joomla\CMS\Log\DelegatingPsrLogger we want them to get the big strikethrough and warning in their IDE, hinting them that something is changing. Hopefully they will look at the core class and figure out what the deprecation is.

In the PR for 5.0 the deprecation is removed. The class is made final and the @internal mark is kept.

@HLeithner HLeithner merged commit 1fc0330 into joomla:4.3-dev Nov 22, 2022
@HLeithner
Copy link
Member

Thanks

@nikosdion nikosdion deleted the architecture/j43-psrlogger-prep branch May 10, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants