Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Migrate quickicon downloadkey plugin to services #39168

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Nov 7, 2022

Summary of Changes

Migrate the quickicon downloadkey plugin to service providers and use SubscriberInterface.

Testing Instructions

  • Install an extension with providing a download key
  • Check if quickicons are still working

image
image

Actual result BEFORE applying this Pull Request

Downloadkey quickicon is working

Expected result AFTER applying this Pull Request

Downloadkey quickicon is working (and the other quickicons are still displayed)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo
Copy link
Member

laoneo commented Nov 8, 2022

@laoneo
Copy link
Member

laoneo commented Nov 8, 2022

I have tested this item ✅ successfully on 3ad401b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168.

@heelc29
Copy link
Contributor Author

heelc29 commented Nov 8, 2022

Guess this here should be lower case as well

Done

@laoneo laoneo added the Maintainers Checked Used if the PR is conceptional useful label Nov 8, 2022
@Abernyte-Git
Copy link

I have tested this item ✅ successfully on 254dcee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168.

@joomla-cms-bot joomla-cms-bot removed the Maintainers Checked Used if the PR is conceptional useful label Nov 8, 2022
@alikon
Copy link
Contributor

alikon commented Nov 8, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 8, 2022
@alikon alikon added the Maintainers Checked Used if the PR is conceptional useful label Nov 8, 2022
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Nov 9, 2022
@obuisard obuisard merged commit 13a59d0 into joomla:4.3-dev Nov 9, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 9, 2022
@obuisard
Copy link
Contributor

obuisard commented Nov 9, 2022

Great work @heelc29. Thank you!

@heelc29
Copy link
Contributor Author

heelc29 commented Nov 9, 2022

Thanks

@heelc29 heelc29 deleted the plugins/quickicon/downloadkey branch November 9, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainers Checked Used if the PR is conceptional useful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants