-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Migrate quickicon downloadkey plugin to services #39168
Merged
obuisard
merged 3 commits into
joomla:4.3-dev
from
heelc29:plugins/quickicon/downloadkey
Nov 9, 2022
Merged
[4.3] Migrate quickicon downloadkey plugin to services #39168
obuisard
merged 3 commits into
joomla:4.3-dev
from
heelc29:plugins/quickicon/downloadkey
Nov 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guess this here should be lower case as well https://github.com/joomla/joomla-cms/pull/39168/files#diff-6886871adeab8130a00db34ba210255b45c247430a320dc497c4ffd88c06ee13R5 |
I have tested this item ✅ successfully on 3ad401b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168. |
Done |
laoneo
approved these changes
Nov 8, 2022
I have tested this item ✅ successfully on 254dcee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168. |
Great work @heelc29. Thank you! |
Thanks |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Migrate the quickicon downloadkey plugin to service providers and use SubscriberInterface.
Testing Instructions
Actual result BEFORE applying this Pull Request
Downloadkey quickicon is working
Expected result AFTER applying this Pull Request
Downloadkey quickicon is working (and the other quickicons are still displayed)
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed