[4][webservices] return tag info on GET content articles #39009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we returning the numeric prefix? That looks incorrect to me. It needs to be in the relationships of the article - such as the comments section in the main json api examples here https://jsonapi.org/ |
|
did you see the response of a GET for a single article? |
|
I have tested this item ✅ successfully on ed5da42 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39009. |
Quy
reviewed
Oct 25, 2022
|
I've restored the previous human test result in the issue tracker so it's properly counted because all changes after that were only code style and a clean branch update. |
|
I have tested this item ✅ successfully on 6b03dca This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39009. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39009. |
|
Thank you for your improvement. |
charvimehradu
pushed a commit
to charvimehradu/joomla-cms
that referenced
this pull request
Jan 26, 2023
Co-authored-by: Quy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
return tags on articles webservice get
Testing Instructions
add some tags to some articles
send a GET to
{{base_url}}/{{base_path}}/content/articlesActual result BEFORE applying this Pull Request
no tag info returned
"tags": []Expected result AFTER applying this Pull Request
tag info returned
"tags": { "1": "aTag" }Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed