[4.3] Migrate the extension finder plugin to services

[laoneo]

Summary of Changes

Migrate the extension finder plugin to services.

Testing Instructions

Install an extension.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Abernyte-Git]

I have tested this item ✅ successfully on e46b1ec

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39006.}

[laoneo]

@heelc29 do you also have time to test this?

[heelc29]

Can you remove the two require -> file is empty

joomla-cms/plugins/extension/finder/src/Extension/Finder.php

Line 162 in 8208f27

require_once JPATH_ADMINISTRATOR . '/components/com_finder/helpers/indexer/helper.php';

joomla-cms/plugins/extension/finder/src/Extension/Finder.php

Line 196 in 8208f27

require_once JPATH_ADMINISTRATOR . '/components/com_finder/helpers/indexer/helper.php';

joomla-cms/administrator/components/com_finder/helpers/indexer/helper.php

Lines 13 to 18 in 17ac356

	/**
	* Finder Indexer Helper class.
	*
	* @since 2.5
	* @deprecated 5.0 Use \Joomla\Component\Finder\Administrator\Indexer\Helper instead
	*/

Import is used

joomla-cms/plugins/extension/finder/src/Extension/Finder.php

Line 16 in 8208f27

use Joomla\Component\Finder\Administrator\Indexer\Helper;

[laoneo]

Thanks for the hint @heelc29, removed it.

[heelc29]

I have tested this item ✅ successfully on 1b619e9

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39006.}

[laoneo]

Setting RTC as only requires are removed which are pointing to an empty file.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39006.}

[obuisard]

Thank you Allon @laoneo!