-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating 4.3-dev with changes from 4.2-dev #38973
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the font a little smaller and italics for the placeholder. This addresses a usability issue where it was not possible to visually determine a difference between placeholder text and input text
…#38796) * Do not checkout a record when the user is not logged in * do not load early * correct return * add test
* Now uses LIBXML_NOERROR
* [4.2] RFC alias error link No idea if this is the _best_ way to do this so feedback appreciated. If/when accepted it can be applied to may similar use cases. pr for joomla#37013 create a menu item called test Try to create a second menu item also called test Before After And the link opens the existing menu item * trashed or not trashed * category trashed check. No link * cs * contact trashed check. no link * cs * cs * cs * newsfeed trashed check, no link * filters can't be trashed or in categories but the language string was wrong * tags trashed check, no link * article trashed check, no link * cs * underline links * simplify * Phase 1 convert BRANCH to PSR-12 * Phase 2 convert BRANCH to PSR-12
* Media Actions - Better UX * fixing order of properties, hopefully this is correct * fixing order of properties, again. * Removing redundant 'item' from media action language strings * Removing redundant 'item' from media action language strings in frontend * Spelling error * CSS display tweaks Helping the actions menu work with longer strings; minor CSS tweaks to the media browser for easier future maintenance. * fixing order of properties again.... * Aria-label and title are unnecessary when there is accessible text in the DOM. * Fixing layering when items are close together. * Adding aria-describedby to buttons to make it clear which item is being managed * Mobile compatibility this is not perfect, but it's better. * Switching to aria-details and moving the span so it doesn't always get read out by screen readers * fixing css property order * Cleaning up aria/a11y attributes and html structure * cleaning up formatting * adding aria-orientation vertical JS looks like it's hooking into the up and down keys; toolbar roles inherit horizontal orientation so we have to specify. * Fix grid item size * fixing javascript keybindings * adding focus style to toggle * ACTUALLy adding focus styles... for real this time * Removing transition delay and making icons have the same transition * making delete hover more clear * Thumbnail size tweaks Making it work more like before by using auto-fill instead of auto-fit. * Codestyle fixes * Capitalizing 'get link' * Update administrator/components/com_media/resources/scripts/components/browser/actionItems/toggle.vue Co-authored-by: Allon Moritz <[email protected]> * Update administrator/components/com_media/resources/scripts/components/browser/actionItems/toggle.vue Co-authored-by: Allon Moritz <[email protected]> * Removing unnecessary newline * Switching to new language string for the item actions toggle. * Removing empty block * Adding deprecation notices to language files Co-authored-by: Allon Moritz <[email protected]>
# Conflicts: # administrator/components/com_tags/src/Table/TagTable.php # administrator/language/en-GB/com_tags.ini
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Language Change
This is for Translators
NPM Resource Changed
This Pull Request can't be tested by Patchtester
Test instructions missing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.