Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to select Url type menu item as Base item in mod_menu #38563

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

brianteeman
Copy link
Contributor

Pull Request for #20556 and multiple closed issues

Create menu consisting of URL type items and subitems of any type(that is important)
Go to Modules -> New -> Menu
Try to select as Base item the URL type items you added

url, alias, heading etc were not selectable. The logic made sense as you can't click on one of those to open a submenu. However as you can open a submenu by hover then it does have a purpose so this PR removes that restriction

@RickR2H
Copy link
Member

RickR2H commented Aug 23, 2022

I have tested this item ✅ successfully on cbdf9f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on cbdf9f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563.

@alikon
Copy link
Contributor

alikon commented Aug 23, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2022
@fancyFranci
Copy link
Contributor

Sorry, but to be sure we are not missing something I'm moving the PR to 4.3. Then we have more tests. Thanks for your work!

@fancyFranci fancyFranci changed the base branch from 4.2-dev to 4.3-dev September 15, 2022 20:36
@brianteeman
Copy link
Contributor Author

Very sad face

@viocassel
Copy link
Contributor

🤨

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Sep 17, 2022
@obuisard obuisard merged commit bf18874 into joomla:4.3-dev Sep 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 17, 2022
@obuisard
Copy link
Contributor

Thank you Brian @brianteeman for the PR.

@brianteeman brianteeman deleted the modal_menu branch September 17, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants