-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to select Url type menu item as Base item in mod_menu #38563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on cbdf9f9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563. |
1 similar comment
I have tested this item ✅ successfully on cbdf9f9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563. |
Sorry, but to be sure we are not missing something I'm moving the PR to 4.3. Then we have more tests. Thanks for your work! |
Very sad face |
🤨 |
Thank you Brian @brianteeman for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for #20556 and multiple closed issues
Create menu consisting of URL type items and subitems of any type(that is important)
Go to Modules -> New -> Menu
Try to select as Base item the URL type items you added
url, alias, heading etc were not selectable. The logic made sense as you can't click on one of those to open a submenu. However as you can open a submenu by hover then it does have a purpose so this PR removes that restriction