[4.2] Change the db calls back to the getDbo

[laoneo]

Pull Request for Issue #38505.

Summary of Changes

When an extension is overriding the getDbo function in a model and returning it's own database instance, then the parent classes are not using it anymore as they use getDatabase now. Correct way would be to inject the database instance through the argument in the constructor config or setDbo/setDatabase.

The following code snippet shows the code issue:

class MyModel extends ListModel {
  private $mydb;
  public function __construct(..) {
    parent::__construct(...);
    $ẗhis->mydb = MyHelper::getGridDB();
  }
  
  public function getDbo() {
    return $this->mydb;
  }
}

Correctly you would write:

class MyModel extends ListModel {
  public function __construct(..) {
    parent::__construct(...);
    $this->setDbo(MyHelper::getGridDB());
  }
}

To maintain full backwards compatibility, this pr changes back the usage to getDbo.

Testing Instructions

Use the extension from issue #38505.

Actual result BEFORE applying this Pull Request

It throws an error.

Expected result AFTER applying this Pull Request

It works as expected.

[roland-d]

@FoTo50 Can you test this pull request please?

[roland-d]

I have tested this item ✅ successfully on f5b8086

After applying the patch the external database connection is being used which it did not use before the patch.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38506.}

[FoTo50]

@FoTo50 Can you test this pull request please?

Thanks very much for this good explanation. This now works just as expected, in 4.1.5 and in 4.2.0

I think this would be a good example to modify https://docs.joomla.org/Connecting_to_an_external_database with since this page is probably for most the starting point when asking Google for it

[laoneo]

Even when this article still uses the old code, it shows you how to do it the correct way, by using the setDbo function and not overriding getDbo. It is not safe to rely on the base class, that it uses all the time getDbo when there is even a protected variable $_db in the BaseDatabaseModel class. So I suggest you adapt your code, as this change will be reverted in 5.0.

Anyway, happy that the pr works also for you now and the issue is fixed.

[roland-d]

@FoTo50 Great to hear it is working again.

Could you please mark your test on our issue tracker as well? All you need to do is:

1. Go to https://issues.joomla.org/tracker/joomla-cms/38506
2. Click Login with Github
3. After you are logged in you can click the Test this blue button
4. Write in the box that it works as expected
5. Click on the Submit test result

This will then be marked here as a human test result and we can get this merged. Thank you.

[FoTo50]

I have tested this item ✅ successfully on f5b8086

works as expected, thnx

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38506.}

[chmst]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38506.}

[fancyFranci]

Thank you very much!