Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] add renovate.json to the exclude list on the build tools #38442

Merged
merged 4 commits into from
Aug 14, 2022

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 12, 2022

Pull Request for Issue # .

Summary of Changes

Add renovate.json to the exclude list on the build tools cc @roland-d @fancyFranci please merge before the stable build. cc @HLeithner

Testing Instructions

review the changes

Actual result BEFORE applying this Pull Request

renovate.json is included within the packages

Expected result AFTER applying this Pull Request

renovate.json is nolonger included within the packages

Documentation Changes Required

n.a.

@HLeithner
Copy link
Member

looks good thanks

@zero-24 zero-24 added this to the Joomla! 4.2.0 milestone Aug 12, 2022
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on fe9b5e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38442.

@fancyFranci
Copy link
Contributor

Could you sort it alphabetical? :D

@tecpromotion
Copy link
Contributor

Also

Installation and Images

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 12, 2022

Something like that @fancyFranci ?

@tecpromotion IIRC Images and installer are handled at other places.

@tecpromotion
Copy link
Contributor

Something like that @fancyFranci ?

@tecpromotion IIRC Images and installer are handled at other places.

image

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 12, 2022

Got it fixed @tecpromotion

@richard67
Copy link
Member

I have tested this item ✅ successfully on 239ed53

By review with knowledge on how build.php works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38442.

@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Aug 13, 2022
@roland-d roland-d merged commit 7c1eb41 into joomla:4.2-dev Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainers Checked Used if the PR is conceptional useful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants