Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] Workaround the a bit off monthsUntilEOS calculation #38317

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Jul 21, 2022

Summary of Changes

The message checks for the EOS plugin depend on the monthsUntilEOS but that calculation is a bit off.

Testing Instructions

  • Install 3.10
  • Notice the "securrity only mode" message
  • Apply this patch
  • you get the Info 2 message
  • modify the eos setting to: const EOS_DATE = '2023-07-17'; (would mean we would be actually in sec only mode already)#
  • notice the "securrity only mode" message came up again

Actual result BEFORE applying this Pull Request

The messages where one month to early

Expected result AFTER applying this Pull Request

The messages come on the expected months

Documentation Changes Required

n.a.

cc @tecpromotion

@zero-24 zero-24 added this to the Joomla! 3.10.11 milestone Jul 21, 2022
@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on ba9c039


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317.

@brianteeman
Copy link
Contributor

Unless there is going to be an update released in the next few weeks this pr (while correct) is pointless.

@zero-24
Copy link
Contributor Author

zero-24 commented Jul 21, 2022

there will be a one more release :-)

@brianteeman
Copy link
Contributor

I forgot about the 6 month notice

@richard67
Copy link
Member

I have tested this item ✅ successfully on 0f7923b

I've played around a bit more with the EOS_DATE than described in the testing instructions.

Due to the calculation of the $monthsUntilEOS with some kind of average month length in days (see https://github.com/joomla/joomla-cms/blob/3.10-dev/plugins/quickicon/eos310/eos310.php#L77 ) the message changes are not accurate by the day, but accurate enough:

const EOS_DATE = '2022-07-22';

=> Support has ended

const EOS_DATE = '2022-07-23';
const EOS_DATE = '2023-01-21';

=> Support ends on ... for Joomla 3.10. Migrate to Joomla 4 as soon as possible.

const EOS_DATE = '2023-01-22';
const EOS_DATE = '2023-07-23';

=> Joomla 3.10 has entered security only mode. Support ends ... Start planning to migrate to Joomla 4 today.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317.

@richard67
Copy link
Member

@tecpromotion Could you redo your test? Thanks in advance.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0f7923b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.10.11 milestone Jul 22, 2022
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 22, 2022
@zero-24 zero-24 added this to the Joomla! 3.10.11 milestone Jul 22, 2022
@zero-24
Copy link
Contributor Author

zero-24 commented Jul 22, 2022

Merging thanks guys :)

@zero-24 zero-24 merged commit f4a39fc into joomla:3.10-dev Jul 22, 2022
@zero-24 zero-24 deleted the monthcalculation branch July 22, 2022 10:37
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants