-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] Workaround the a bit off monthsUntilEOS calculation #38317
Conversation
I have tested this item ✅ successfully on ba9c039 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317. |
Unless there is going to be an update released in the next few weeks this pr (while correct) is pointless. |
there will be a one more release :-) |
I forgot about the 6 month notice |
I have tested this item ✅ successfully on 0f7923b Due to the calculation of the $monthsUntilEOS with some kind of average month length in days (see https://github.com/joomla/joomla-cms/blob/3.10-dev/plugins/quickicon/eos310/eos310.php#L77 ) the message changes are not accurate by the day, but accurate enough: const EOS_DATE = '2022-07-22'; => Support has ended const EOS_DATE = '2022-07-23'; => Support ends on ... for Joomla 3.10. Migrate to Joomla 4 as soon as possible. const EOS_DATE = '2023-01-22'; => Joomla 3.10 has entered security only mode. Support ends ... Start planning to migrate to Joomla 4 today. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317. |
@tecpromotion Could you redo your test? Thanks in advance. |
I have tested this item ✅ successfully on 0f7923b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317. |
Merging thanks guys :) |
Summary of Changes
The message checks for the EOS plugin depend on the monthsUntilEOS but that calculation is a bit off.
Testing Instructions
Actual result BEFORE applying this Pull Request
The messages where one month to early
Expected result AFTER applying this Pull Request
The messages come on the expected months
Documentation Changes Required
n.a.
cc @tecpromotion