[4.2] Fix fatal error on webauthn plugin #38132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
PR #38060 removed
$app
property from the class, so using$this->app
in the layout causes fatal error. We need to use$this->getApplication()
to get application object instead.I also removed an un-used use statement in the plugin layout code.
Testing Instructions
I don't have experience with using the plugin, so please ignore if my testing instructions are wrong
Actual result BEFORE applying this Pull Request
Get fatal error: Call to a member function getDocument() on null
Expected result AFTER applying this Pull Request
Error is gone, the page loads OK