Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Convert the checkfiles plugin to service provider #38072

Merged
merged 23 commits into from
Jul 3, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jun 16, 2022

Summary of Changes

Converts the checkfiles plugin to service provider and adds some unit tests. This pr is based on #38060, so please test that one first.

Testing Instructions

  • Create a folder in images with the name test and upload there a big image from unsplash or so which is bigger than 1080 pixels
  • Go to the task scheduler back end list
  • Click on new "Image Size Check"
  • Select the test image in the task parameters
  • Save the task and close the form
  • Run the task by clicking on "Run Test" button

Actual result BEFORE applying this Pull Request

The image in the test folder has a width or height of 1080 pixels.

Expected result AFTER applying this Pull Request

The image in the test folder has a width or height of 1080 pixels.

@alikon
Copy link
Contributor

alikon commented Jun 22, 2022

I have tested this item ✅ successfully on db97381


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38072.

@joomla-bot
Copy link
Contributor

A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#24

@HLeithner
Copy link
Member

A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#24

there was a merge error on this pull request please check if worked correctly

@laoneo laoneo closed this Jun 28, 2022
@laoneo laoneo force-pushed the j4/plugins/checkfiles branch from 76900de to 2f45696 Compare June 28, 2022 05:41
@laoneo laoneo reopened this Jun 28, 2022
@laoneo laoneo closed this Jun 28, 2022
@laoneo laoneo force-pushed the j4/plugins/checkfiles branch from 4e1a42e to dd91072 Compare June 28, 2022 05:46
@laoneo laoneo reopened this Jun 28, 2022
@laoneo
Copy link
Member Author

laoneo commented Jun 28, 2022

I had to redo this pr, @heelc29 can you have a look again if I missed something. Thanks!

Copy link
Contributor

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same changes 😅

richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 24, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants