-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Convert the checkfiles plugin to service provider #38072
Conversation
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
I have tested this item ✅ successfully on db97381 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38072. |
A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#24 |
there was a merge error on this pull request please check if worked correctly |
76900de
to
2f45696
Compare
4e1a42e
to
dd91072
Compare
I had to redo this pr, @heelc29 can you have a look again if I missed something. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same changes 😅
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: heelc29 <[email protected]>
Summary of Changes
Converts the checkfiles plugin to service provider and adds some unit tests. This pr is based on #38060, so please test that one first.
Testing Instructions
Actual result BEFORE applying this Pull Request
The image in the test folder has a width or height of 1080 pixels.
Expected result AFTER applying this Pull Request
The image in the test folder has a width or height of 1080 pixels.