Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] tag active focus #37877

Merged
merged 4 commits into from
May 28, 2022
Merged

[4.1] tag active focus #37877

merged 4 commits into from
May 28, 2022

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #37864 .

Summary of Changes

add a margin around the tags so that the focus ring is displayed correctly

Testing Instructions

This is a css change so either use a pre-built package or npm run build:css

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

n/a

@chmst
Copy link
Contributor

chmst commented May 24, 2022

I have tested this item ✅ successfully on 3fa7b26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877.

1 similar comment
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 3fa7b26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877.

@alikon
Copy link
Contributor

alikon commented May 24, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels May 24, 2022
@Quy Quy added this to the Joomla 4.1.5 milestone May 24, 2022
@Quy Quy added the PR-4.1-dev label May 24, 2022
@Quy Quy removed this from the Joomla 4.1.5 milestone May 24, 2022
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label May 26, 2022
@richard67
Copy link
Member

@brianteeman After I had updated your branch to make the npm step pass in drone, the scss code style check fails in drone: https://ci.joomla.org/joomla/joomla-cms/54621/1/24 .

@brianteeman
Copy link
Contributor Author

Thanks for fixing drone. I thought it might have been better as short hand but couldnt remember if we just left that to the compiler..

@sandewt
Copy link
Contributor

sandewt commented May 26, 2022

Thanks

@Quy Quy added this to the Joomla 4.1.5 milestone May 28, 2022
@Quy Quy merged commit 74a99fa into joomla:4.1-dev May 28, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 28, 2022
@Quy
Copy link
Contributor

Quy commented May 28, 2022

Thanks

@brianteeman brianteeman deleted the tags branch May 29, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants