-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] tag active focus #37877
[4.1] tag active focus #37877
Conversation
I have tested this item ✅ successfully on 3fa7b26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877. |
1 similar comment
I have tested this item ✅ successfully on 3fa7b26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877. |
@brianteeman After I had updated your branch to make the npm step pass in drone, the scss code style check fails in drone: https://ci.joomla.org/joomla/joomla-cms/54621/1/24 . |
build/media_source/templates/site/cassiopeia/scss/blocks/_tags.scss
Outdated
Show resolved
Hide resolved
Thanks for fixing drone. I thought it might have been better as short hand but couldnt remember if we just left that to the compiler.. |
….scss Co-authored-by: Richard Fath <[email protected]>
Thanks |
Thanks |
Pull Request for Issue #37864 .
Summary of Changes
add a margin around the tags so that the focus ring is displayed correctly
Testing Instructions
This is a css change so either use a pre-built package or npm run build:css
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
n/a