[5.0] [new feature] TinyMce sample image plugin

[brianteeman]

This is a toolbar icon for the tinymce editor that will let you quickly generate a placeholder image in your content.

To test

1. Apply pr
2. rebuild the js with npm run build:js
3. Go to the tinymce plugin and drag the new icon to your toolbar
4. Go to any article and try it you

Plugin

Demo

[laoneo]

Why do you need that? I don't think this needs to come in core. Write a plugin and load it through the plugin feature if you need it.

[brianteeman]

It speeds up development and makes life easier to build a site. Feedback was very positive when I showed the concept on FB. We have to start treating tinymce as a first class citizen. Instead we push people to use an editor that is old and outdate but has the extras people need.

[laoneo]

Don't agree here. The core should act as an example and doesn't need to compete out 3rd party extensions. Bloating the core with such useless features which will not bring any benefit to the users is a wrong direction. Instead of, you should tell the users how extensible the core editor is and make an example of this use case either in the official docs or in a magazine post.

[brianteeman]

I couldnt disagree more

[Fedik]

I think the idea is good, can be useful for authors, it allow to format the article and replace images to final ones later.

[HLeithner]

I don't think it should be in core if it's possible to do it with a Plugin. A 3rd Party Plugin could also use 3rd Party image services.

[Fedik]

I know, but that something that Writers would like to see in core.

[brianteeman]

@HLeithner you are missing the point. Core must be usable and useful. It doesnt matter how fast the code is or how modern the code is. What matters is that users can use it. Why should they have to install a plugin for something that is 40 lines of code. You can make the argument about making it a 3rd party extension with every new feature added to core in J4. Workflows -> almost unusable in its current form without extra code. Schedule -> completely unusable without extra code. Media Manager - the least said abut the better.
PS it is not possible to do this with an installable plugin that is fully integrated into the editor

[brianteeman]

Forgot to add. I actually did some (rudimentary) user research before even starting this. When was the last time anyone did that

[laoneo]

TinyMCE has a feature where you can load TinyMCE plugins by adding it to the options. We do not talk here about a Joomla plugin.

[brianteeman]

You can make this argument about everything. Its a stupid argument. We must make joomla usable.

[brianteeman]

TinyMCE has a feature where you can load TinyMCE plugins by adding it to the options. We do not talk here about a Joomla plugin.

Show me how a joomla user can install that plugin. There is no functionality for that.

[laoneo]

The part on the bottom:

I'm using it on my production sites with the autolink plugin.

[Fedik]

@laoneo please do not forget that Joe Average does not have a skills to code it (and this plugin exists nowhere) 😉
He want to write a text.

[brianteeman]

@laoneo I am well aware of that option. Still doesn't answer the fact that there is no way on joomla to install that plugin.

There has been more lines of comment than there has been code

[laoneo]

Instead of, you should tell the users how extensible the core editor is and make an example of this use case either in the official docs or in a magazine post.

Again, publish your sample lines and tell the world how extensible it is.

@laoneo I am well aware of that option. Still doesn't answer the fact that there is no way on joomla to install that plugin.

Uploading it via FTP or the template editor is enough. There is really nothing to install here. Again, this is a great showcase how to use the plugin feature of TinyMCE.

[laoneo]

@laoneo please do not forget that Joe Average does not have a skills to code it (and this plugin exists nowhere) wink He want to write a text.

Copy paste is enough for the few people who are using it.

[brianteeman]

I wonder how you would have reacted if I had told you to just write a blog post about custom fields. No need for that to be in the core. Just copy paste code, use ftp etc.

[laoneo]

I wonder how you would have reacted if I had told you to just write a blog post about custom fields. No need for that to be in the core. Just copy paste code, use ftp etc.

It's ok, no need to shift away. I shared my opinion. Do whatever you guys want. It really doesn't matter if this feature is in or not at the end of the day.

[RickR2H]

I have tested this item ✅ successfully on fa08447

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36968.}

[brianteeman]

closed due to lack of interest from release lead

[HLeithner]

This pull request has been automatically rebased to 5.0-dev.

[fancyFranci]

I have tested this item 🔴 unsuccessfully on fa08447

First the icon did not load in the Tinymce plugin view, just the placeholder text. After reloading the page the icon appeared as expected. I can drag it to my toolbar and save it. But then I can not open the article any more. A soon as I revert the patch its working again. I think placeholder images are really useful, would be great if you can fix that.

"An error has occurred.
0 Call to a member function getIdentity() on null "

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36968.}

[brianteeman]

I can't replicate your issue got confused with another pr

[HLeithner]

I have tested this item 🔴 unsuccessfully on fa08447First the icon did not load in the Tinymce plugin view, just the placeholder text. After reloading the page the icon appeared as expected. I can drag it to my toolbar and save it. But then I can not open the article any more. A soon as I revert the patch its working again. I think placeholder images are really useful, would be great if you can fix that.

"An error has occurred. 0 Call to a member function getIdentity() on null "

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36968.

a trace log would be helpful

[fancyFranci]

a trace log would be helpful

You're right.

[HLeithner]

@Fedik could this be of the change from pseudo event buttons to real events?
@laoneo or did you missed something for identity here?

[fancyFranci]

@HLeithner I really dont know why, but after I tested #36975 with the same result, I went back to here, installed again and the error is gone now... Inserting sample images works as expected.

[fancyFranci]

I have tested this item ✅ successfully on e2ada52

I was able to add sample images into my article

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36968.}

[fancyFranci]

The error comes back when I remove the other new plugin (sample text) from the tinymce toolbar. After I tested it and left it there, the sample image worked.

[Fedik]

could this be of the change from pseudo event buttons to real events?

Nope, this can happen when $application not injected in to plugin while bootPlugin,

joomla-cms/plugins/editors/tinymce/src/PluginTraits/DisplayTrait.php

Line 70 in 6ba6cbd

$user = $this->getApplication()->getIdentity();

It nothing with events.
But it should be injected already

joomla-cms/plugins/editors/tinymce/services/provider.php

Line 41 in 79f439d

$plugin->setApplication(Factory::getApplication());

[Fedik]

@fancyFranci did you tested iit for joomla 5 or 4? because title say 4,but the target is 5 :)

[N6REJ]

I have tested this item 🔴 unsuccessfully on e2ada52 using J5.0-dev

applying the patch causes tinymce to no longer appear

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36968.}

pre-patch

Post patch

[brianteeman]

a trace log would be helpful

[brianteeman]

The PR was created for Joomla 4.2 using tinymce 5. @HLeithner changed this to be for 5.0 but as that uses tinymce 6 and a reworked plugin tbh I wouldnt expect this to work at all.

[N6REJ]

The PR was created for Joomla 4.2 using tinymce 5. @HLeithner changed this to be for 5.0 but as that uses tinymce 6 and a reworked plugin tbh I wouldnt expect this to work at all.

ok, so this fails j5.

[HLeithner]

same as the other pr, why not using the template system for this?

[brianteeman]

why not using the template system for this?

because the template system is not easily portable and is template dependent

[HLeithner]

didn't we had a standard set/location in joomla too? or was this located only in Cassiopiea? Anyway tinymce deprecated the "simple" template system for there paid advanced template system. So we forked it and maybe @Fedik or @dgrammatiko or @laoneo has a nice idea for a better template system for such cases.

[Fedik]

Following code is looking for templates

joomla-cms/plugins/editors/tinymce/src/Extension/TinyMCE.php

Lines 65 to 67 in ad7796a

	$filepaths = Folder::exists(JPATH_ROOT . '/templates/' . $template)
	? Folder::files(JPATH_ROOT . '/templates/' . $template, '\.(html|txt)$', false, true)
	: [];

Not sure what exactly, I think @dgrammatiko know better.
It is part of #40626

[Fedik]

it maybe a good idea to have some default templates under /media/plg_editors_tinymce/templates/

[dgrammatiko]

Not sure what exactly, I think @dgrammatiko know better.

That ajax fn just replaced the code that resolved the templates on startup (now it's per use case)

it maybe a good idea to have some default templates under /media/plg_editors_tinymce/templates/

It's very easy to add one more lookup path in the code you linked above #36968 (comment)

[brianteeman]

do it without me. wasted enough time on making a good editor for joomla already without an 18 month delay to everything