[3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible #36794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101` and a few more (line 35, line 53, line 115)
beat
changed the title
|
Making WIP, protostar has same issue, maybe beez too,more commits coming. |
Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/protostar/html/modules.php on line 47`
Fixes errors like `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in templates/beez/html/modules.php on line 42`
beat
changed the title
|
Removed WIP, ready for review. |
|
I have tested this item ✅ successfully on fcd5647 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36794. |
|
I have tested this item ✅ successfully on fcd5647 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36794. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36794. |
|
Merging thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # none
Summary of Changes
Fixes
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101and a few more (line 35, line 53, line 115)and same in Protostar and Beez modules.php
Testing Instructions
Code review.
Or see front-end with PHP 8.1, debug ON, and all PHP errors on.
Actual result BEFORE applying this Pull Request
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101and in some other cases:
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 35Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 53Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 115Expected result AFTER applying this Pull Request
not those warnings anymore.
Documentation Changes Required
None.