-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] Fix open_basedir warning when creating a menu item #36789
Conversation
I have tested this item ✅ successfully on 729f382 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789. |
I have tested this item ✅ successfully on 729f382 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789. |
1 similar comment
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789. |
Hmm that method is setup far from ideal as it depends on cases and not in all cases the variables are setup correctly. For example this issue here comes only up when the "option" == component can not be found. When that has been found it will fallback to the component root. But this patch here is right as we can not try to fallback to the component root when we do not have any information about it :) Thanks |
I have tested this item ✅ successfully on 729f382 J 3.10.5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789. |
I have tested this item ✅ successfully on 729f382 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789. |
Pull Request for Issue #36788 and #35895 .
Summary of Changes
Correctly check path
Testing Instructions
Follow #36788 and #35895
Actual result BEFORE applying this Pull Request
A warning about open_basedir stuff
Expected result AFTER applying this Pull Request
No warning
Documentation Changes Required
None