Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] Fix open_basedir warning when creating a menu item #36789

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jan 22, 2022

Pull Request for Issue #36788 and #35895 .

Summary of Changes

Correctly check path

Testing Instructions

Follow #36788 and #35895

Actual result BEFORE applying this Pull Request

A warning about open_basedir stuff

Expected result AFTER applying this Pull Request

No warning

Documentation Changes Required

None

@ChristineWk
Copy link

I have tested this item ✅ successfully on 729f382

J 3.10.5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 729f382

Tested on a copy of my homepage on my domain, where I have and always had open_basedir restrictions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

1 similar comment
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 23, 2022
@richard67 richard67 added this to the Joomla 3.10.6 milestone Jan 23, 2022
@zero-24
Copy link
Contributor

zero-24 commented Jan 23, 2022

Hmm that method is setup far from ideal as it depends on cases and not in all cases the variables are setup correctly. For example this issue here comes only up when the "option" == component can not be found. When that has been found it will fallback to the component root. But this patch here is right as we can not try to fallback to the component root when we do not have any information about it :)

Thanks

@zero-24 zero-24 merged commit c7cf2dc into joomla:3.10-dev Jan 23, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 23, 2022
@Fedik Fedik deleted the fix-menu-error310 branch January 23, 2022 15:13
@silverislander
Copy link

I have tested this item ✅ successfully on 729f382

Tested successfully on a client website (managed hosting).

J 3.10.5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

@TLWebdesign
Copy link

I have tested this item ✅ successfully on 729f382

Tested this PR on 3.10 and can confirm this fixed the warning.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants