-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Finder: Enforce Taxonomies to contain a title #36759
Conversation
Followed test instructions and was unable to replicate the reported problem |
This pull requests has been automatically converted to the PSR-12 coding standard. |
I have tested this item ✅ successfully on 28dc8cc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759. |
I was not able to reproduce the issue. We need better guidance to reproduce the issue... This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759. |
From code review it looks like a valid fix. joomla-cms/administrator/components/com_finder/src/Table/MapTable.php Lines 63 to 65 in f520c98
The taxonomy title requirement was introduced in #21327 |
I have tested this item ✅ successfully on 7050d69 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759. |
I have tested this item ✅ successfully on 7050d69 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759. |
Thanks! |
Pull Request for Issue #35977.
Summary of Changes
If a finder plugin tries to add an empty taxonomy, this can fail with the error message from #35977. This PR should fix that. This most likely is an article with a non-existing author or something similar.
Testing Instructions
Unfortunately I can't replicate the issue from #35977 and the below testing instructions seem to not be able to replicate the problem. Maybe @Stuartemk can investigate this further and try to test this?
Actual result BEFORE applying this Pull Request
It fails with the above error message (An Error Has Occurred Category must have a title.)
Expected result AFTER applying this Pull Request
Everything is properly indexed.