Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Finder: Enforce Taxonomies to contain a title #36759

Merged
merged 16 commits into from
Oct 21, 2022

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 20, 2022

Pull Request for Issue #35977.

Summary of Changes

If a finder plugin tries to add an empty taxonomy, this can fail with the error message from #35977. This PR should fix that. This most likely is an article with a non-existing author or something similar.

Testing Instructions

Unfortunately I can't replicate the issue from #35977 and the below testing instructions seem to not be able to replicate the problem. Maybe @Stuartemk can investigate this further and try to test this?

  1. Create a user.
  2. Create an article and set the author of the article to the previously created user.
  3. Delete the user.
  4. Clear your search index and rebuild it.

Actual result BEFORE applying this Pull Request

It fails with the above error message (An Error Has Occurred Category must have a title.)

Expected result AFTER applying this Pull Request

Everything is properly indexed.

@brianteeman
Copy link
Contributor

Followed test instructions and was unable to replicate the reported problem

@Hackwar Hackwar marked this pull request as draft February 3, 2022 10:06
@Hackwar Hackwar changed the base branch from 4.1-dev to 4.2-dev June 21, 2022 10:50
@Hackwar Hackwar changed the title [4.1] Finder: Enforce Taxonomies to contain a title [4.2] Finder: Enforce Taxonomies to contain a title Jun 21, 2022
@Quy Quy added PR-4.2-dev and removed PR-4.2-dev labels Jun 21, 2022
@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@Hackwar Hackwar marked this pull request as ready for review July 4, 2022 14:14
@danpdanp
Copy link

I have tested this item ✅ successfully on 28dc8cc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.

@RickR2H
Copy link
Member

RickR2H commented Jul 29, 2022

I was not able to reproduce the issue. We need better guidance to reproduce the issue...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.

@Hackwar Hackwar changed the base branch from 4.2-dev to 4.3-dev August 30, 2022 11:13
@Hackwar Hackwar changed the title [4.2] Finder: Enforce Taxonomies to contain a title [4.3] Finder: Enforce Taxonomies to contain a title Aug 30, 2022
@Fedik
Copy link
Member

Fedik commented Sep 25, 2022

From code review it looks like a valid fix.
The error comes from table class

// Check for a title.
if (trim($this->title) == '') {
$this->setError(Text::_('JLIB_DATABASE_ERROR_MUSTCONTAIN_A_TITLE_CATEGORY'));

The taxonomy title requirement was introduced in #21327
I suspect User may have some custom finder plugin, that not adapted it.

@Fedik
Copy link
Member

Fedik commented Sep 25, 2022

I have tested this item ✅ successfully on 7050d69

On review looks valid, everything still works, I count it as success :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.

@Quy Quy removed the PR-4.2-dev label Sep 25, 2022
@RickR2H
Copy link
Member

RickR2H commented Oct 20, 2022

I have tested this item ✅ successfully on 7050d69

Even when I could not reproduce the issue, it also doesn't break things. I tested all the search options and everything seems to be okay. That's a good test IMHO.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.

@RickR2H
Copy link
Member

RickR2H commented Oct 20, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 20, 2022
@laoneo laoneo merged commit bcf6415 into joomla:4.3-dev Oct 21, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 21, 2022
@laoneo
Copy link
Member

laoneo commented Oct 21, 2022

Thanks!

@laoneo laoneo added this to the Joomla! 4.3.0 milestone Oct 21, 2022
@Hackwar Hackwar deleted the patch-1 branch April 17, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants