[4.1] Update deleted files and folders to changes from PR #36097 #36618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx |
richard67
deleted the
4.1-dev-update-deleted-files-and-folders-2022-01-09
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Update deleted files and folders to changes from PR #36097
With that PR, file '/api/components/com_media/src/Helper/AdapterTrait.php' has been moved to another place, see here: https://github.com/joomla/joomla-cms/pull/36097/files#diff-1a2d837d1837d03537622e5a3a17a9c4a41ace8ffe4872f703a783aa390a597e .
After that, the folder '/api/components/com_media/src/Helper' doesn't exist anymore in the sources and so will be empty on an updated site when the obsolete file has been deleted, see here: https://github.com/joomla/joomla-cms/tree/4.1-dev/api/components/com_media/src .
So the file and the folder should be deleted on update.
Regarding the comment "// From 4.1.0-beta3 to 4.1.0-rc1": According to the last release announcement for 4.1 Beta 3, RC will come as next. I hope I was not too optimistic with my comment.
Testing Instructions
Code review, or build new packages on the current 4.1-dev branch (PR #36097 is not yet included in any nightly build) and update a 4.1 Beta 3 to the newly built update package. The update a 4.1 Beta 3 to the update package created by drone for this PR here, and compare the results.
Actual result BEFORE applying this Pull Request
File '/api/components/com_media/src/Helper/AdapterTrait.php' and folder '/api/components/com_media/src/Helper' are not deleted on update.
Expected result AFTER applying this Pull Request
File '/api/components/com_media/src/Helper/AdapterTrait.php' and folder '/api/components/com_media/src/Helper' are deleted on update.
Documentation Changes Required
None.