Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Fix quote markup in language string #36173

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Dec 1, 2021

Summary of Changes

Quotes that are not starting/ending in the language string should be escaped.

Testing Instructions

Code review.
or
Go to System > Administrator Templates
Create a Child Template.
In the list, view page source.

Actual result BEFORE applying this Pull Request

Child of <strong class=text-capitalize text-light>cassiopeia</strong>

Expected result AFTER applying this Pull Request

Child of <strong class="text-capitalize text-light">cassiopeia</strong>

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Dec 1, 2021
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on f62a678


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36173.

1 similar comment
@infograf768
Copy link
Member

I have tested this item ✅ successfully on f62a678


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36173.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-4.1-dev labels Dec 1, 2021
@infograf768
Copy link
Member

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36173.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 1, 2021
@richard67 richard67 added Language Change This is for Translators PR-4.1-dev labels Dec 1, 2021
@bembelimen bembelimen merged commit ea1213f into joomla:4.1-dev Dec 1, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 1, 2021
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1 milestone Dec 1, 2021
@Quy Quy deleted the language-markup branch December 1, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants