Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Show help for system menuitems #35523

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Sep 9, 2021

When you try to use the "Help" button for a system menuitem like "Menu Heading" or "URL" you get a generic help screen instead of the one for the menuitemtype

Summary of Changes

The lookup for the XML was looking in the wrong path for system menuitems.

Testing Instructions

Try the help button for "System Links" menuitem types

Actual result BEFORE applying this Pull Request

Generic help

Expected result AFTER applying this Pull Request

Specific help

Documentation Changes Required

@Bakual Bakual changed the title [4.0Lookup correct form path [4.0] Show help for system menuitems Sep 9, 2021
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on b0918e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35523.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on b0918e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35523.

@chmst chmst removed the PR-4.0-dev label Sep 10, 2021
@chmst
Copy link
Contributor

chmst commented Sep 10, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35523.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 10, 2021
@chmst chmst added this to the Joomla 4.0.3 milestone Sep 10, 2021
@wilsonge wilsonge merged commit 36d0214 into joomla:4.0-dev Sep 10, 2021
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 10, 2021
@Bakual Bakual deleted the 4_LoadAdminMenuitemForm branch September 10, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants