-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Eliminating cpanel jumping #35069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-4.0-dev
labels
Aug 8, 2021
brianteeman
reviewed
Aug 8, 2021
brianteeman
reviewed
Aug 8, 2021
brianteeman
reviewed
Aug 8, 2021
Co-authored-by: Brian Teeman <[email protected]>
I have tested this item ✅ successfully on bf0a8cc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35069. |
I have tested this item ✅ successfully on bf0a8cc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35069. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35069. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The patch should eliminate cpanel jumping, or at least reduce it much.
I have delayed all AJAX request to wait until the content is rendered.
And improved MasonryLayout calculation a bit.
Testing Instructions
Apply patch. Run
npm install
.Visit backend Dashboard and System section.
Actual result BEFORE applying this Pull Request
Notice that "Update Checks" runs immediately.
And cpanel boxes jumps a bit.
Expected result AFTER applying this Pull Request
"Update Checks" runs with a delay, only after the page is loaded.
And cpanel boxes does not jump.
Documentation Changes Required
nope