Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Eliminating cpanel jumping #35069

Merged
merged 8 commits into from
Aug 9, 2021
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Aug 8, 2021

Pull Request for Issue # .

Summary of Changes

The patch should eliminate cpanel jumping, or at least reduce it much.
I have delayed all AJAX request to wait until the content is rendered.
And improved MasonryLayout calculation a bit.

Testing Instructions

Apply patch. Run npm install.
Visit backend Dashboard and System section.

Actual result BEFORE applying this Pull Request

Notice that "Update Checks" runs immediately.
And cpanel boxes jumps a bit.

Expected result AFTER applying this Pull Request

"Update Checks" runs with a delay, only after the page is loaded.
And cpanel boxes does not jump.

Documentation Changes Required

nope

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 8, 2021
Fedik and others added 2 commits August 8, 2021 13:35
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on bf0a8cc

works great!!
tested all dashboards with and without sidemenu


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35069.

@richard67
Copy link
Member

I have tested this item ✅ successfully on bf0a8cc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35069.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35069.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 8, 2021
@wilsonge wilsonge merged commit a73153e into joomla:4.0-dev Aug 9, 2021
@wilsonge
Copy link
Contributor

wilsonge commented Aug 9, 2021

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 9, 2021
@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 9, 2021
@Fedik Fedik deleted the quickic-ajax branch August 9, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants