-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] fix the path for Cassiopeia js #35024
Conversation
40d33d0
to
fe15fec
Compare
Why? This is not Cassiopeia specific |
The child templates are already configured (check the HTML helper file for the overrides) to look at the folders |
Sorry was reading on my phone. Ignore my comment |
OK Let's get a quick test but this looks good to me |
I have tested this item ✅ successfully on fe15fec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024. |
I have tested this item ✅ successfully on fe15fec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024. |
Thanks! |
Pull Request for Issue # .
Summary of Changes
menu-metismenu.es6.js
frombuild/media_source/templates/cassiopeia/js/mod_menu/
tobuild/media_source/templates/site/cassiopeia/js/mod_menu/
(there is asite
missing there)Testing Instructions
Enable the dropdown layout for the frontend menu. Check that the metismenu script is loaded
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
@wilsonge this is kinda important for the Child templates
@richard67 I think you need to add the old paths to the files removed