Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] fix the path for Cassiopeia js #35024

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • Moved the file menu-metismenu.es6.js from build/media_source/templates/cassiopeia/js/mod_menu/ to build/media_source/templates/site/cassiopeia/js/mod_menu/ (there is a site missing there)
  • Adjust the layout to use the correct path

Testing Instructions

Enable the dropdown layout for the frontend menu. Check that the metismenu script is loaded

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@wilsonge this is kinda important for the Child templates
@richard67 I think you need to add the old paths to the files removed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 2, 2021
@brianteeman
Copy link
Contributor

Why?

This is not Cassiopeia specific

@dgrammatiko
Copy link
Contributor Author

Why?

The child templates are already configured (check the HTML helper file for the overrides) to look at the folders media/templates/site and media/templates/administrator depending on if the template is front end or back end. The current path was picked out of the blue, it doesn't follow any rules...

@brianteeman
Copy link
Contributor

Sorry was reading on my phone. Ignore my comment

@wilsonge
Copy link
Contributor

wilsonge commented Aug 2, 2021

OK Let's get a quick test but this looks good to me

@RickR2H
Copy link
Member

RickR2H commented Aug 2, 2021

I have tested this item ✅ successfully on fe15fec

Path is correct and script is loaded after the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024.

@richard67 richard67 added this to the Joomla 4.0 milestone Aug 2, 2021
@jwaisner
Copy link
Member

jwaisner commented Aug 2, 2021

I have tested this item ✅ successfully on fe15fec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Aug 2, 2021
@jwaisner
Copy link
Member

jwaisner commented Aug 2, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 2, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Aug 2, 2021
@wilsonge wilsonge merged commit bdc8320 into joomla:4.0-dev Aug 4, 2021
@wilsonge
Copy link
Contributor

wilsonge commented Aug 4, 2021

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 4, 2021
@dgrammatiko dgrammatiko deleted the 4.0-dev-fix-path branch August 5, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants